-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to PHPstan 2 and Rector 2 #312
base: main
Are you sure you want to change the base?
Conversation
Rector has stable release, can we merge this now? |
This could be merged, but needs updating i think in regards to the version numbers it seems, we'd want to work from stable right? |
Yes, and I think PHP ^7.4 is supported, so change in .github/workflows/functional_test__rector_examples.yml is not needed |
I bumped the rector dependency to I agree with @Holo96 that it would be nice to have drupal-rector 2.0 to match phpstan-drupal 2.0 and rector 2.0. Maintainers, please feel free to edit this MR however you like; as stating in the first post, I opened this as an experiment to test the feasibility of moving to phpstan 2.0. |
…ecations' into phpstan2
Ok, i did some things to make compativbility happen. Right now it tests on 1 and 2, since it seems that might juist be possibel. Unfortunately it seems that AnnotationToAttribute rector breaks in phpstan 2 right now. There might be more breaking tests. I'm considering also to drop Drupal8 support, but not sure yet if that is needed. |
…ecations' into phpstan2
Fixed a few more things thta were weird. Only real issue remaining is the broken AnnotationToAttributeRector |
…ns because of changes in phpparser
Description
Updates to Rector 2 + PHPStan 2
To Test
Drupal.org issue
https://www.drupal.org/project/rector/issues/3493467